Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce snake case in DM proc names. #11355

Closed
wants to merge 13 commits into from
Closed

Enforce snake case in DM proc names. #11355

wants to merge 13 commits into from

Conversation

PowerfulBacon
Copy link
Member

@PowerfulBacon PowerfulBacon commented Aug 21, 2024 •
edited
Loading

About The Pull Request

Enforce snake case in DM proc names, consistency and following a standard is good.

There are exceptions, capitalisation is allowed if the proc name is entirely capitalised, or if the section before or after an underscore is entirely capitalised. This means REF is valid, and get_REF is also valid.

TODO:

  • Allow certain files such as TGS to be excluded.
  • Write a program to go ahead and update all these things.

Why It's Good For The Game

Consistency is good, following proper code standards is good as it makes the code appear cleaner.

Testing Photographs and Procedure

See tests.

Renamed procs:

- proc/Shutdown -> proc/shutdown - proc/Recover -> proc/recover - proc/Recreate_MC -> proc/recreate_mc - proc/Processing -> proc/processing - proc/Trigger -> proc/trigger - proc/Available -> proc/available - proc/Activate -> proc/activate - proc/Deactivate -> proc/deactivate - proc/Cooldown -> proc/cooldown - proc/getArmor -> proc/get_armor - proc/modifyRating -> proc/modify_rating - proc/Ratings -> proc/ratings - proc/setRating -> proc/set_rating - proc/getRating -> proc/get_rating - proc/getList -> proc/get_list - proc/attachArmor -> proc/attach_armor - proc/detachArmor -> proc/detach_armor - proc/Choices -> proc/choices - proc/Cinematic -> proc/cinematic - proc/Teleport -> proc/teleport - proc/addCitation -> proc/add_citation - proc/removeCitation -> proc/remove_citation - proc/payCitation -> proc/pay_citation - proc/addCrime -> proc/add_crime - proc/removeCrime -> proc/remove_crime - proc/Details -> proc/details - proc/Disconnect -> proc/disconnect - proc/Failure -> proc/failure - proc/make_Traitor -> proc/make_traitor - proc/make_Contractor_Support -> proc/make_contractor_support - proc/make_Changeling -> proc/make_changeling - proc/make_Wizard -> proc/make_wizard - proc/make_Cultist -> proc/make_cultist - proc/make_Rev -> proc/make_rev - proc/removeSoulsharer -> proc/remove_soulsharer - proc/parseArgs -> proc/parse_args - proc/ownerDies -> proc/owner_dies - proc/sharerDies -> proc/sharer_dies - proc/setDefault -> proc/set_default - proc/assertFormat -> proc/assert_format - proc/resetFormat -> proc/reset_format - proc/isZooming -> proc/is_zooming - proc/Default -> proc/default - proc/setBoth -> proc/set_both - proc/setWidth -> proc/set_width - proc/setHeight -> proc/set_height - proc/getView -> proc/get_view - proc/zoomOut -> proc/zoom_out - proc/Through -> proc/through - proc/Shuttle -> proc/shuttle - proc/Proximity -> proc/proximity - proc/Processing -> proc/processing - proc/Processing -> proc/processing - proc/setOpened -> proc/set_opened - proc/setClosed -> proc/set_closed - proc/AIController -> proc/aicontroller - proc/Move_Pulled -> proc/move_pulled - proc/forceMove -> proc/force_move - proc/Nullspace -> proc/nullspace - proc/setMovetype -> proc/set_movetype - proc/Process_Spacemove -> proc/process_spacemove - proc/Through -> proc/through - proc/Genesis -> proc/genesis - proc/Adjacent -> proc/adjacent - proc/changeNext_move -> proc/change_next_move - proc/Obscured -> proc/obscured - proc/Interact -> proc/interact - proc/Adjacent -> proc/adjacent - proc/Autoclick -> proc/autoclick - proc/Mousedown -> proc/mousedown - proc/Autoclick -> proc/autoclick - proc/Autoclickable -> proc/autoclickable - proc/Quadratic -> proc/quadratic - proc/Contents -> proc/contents - proc/Ignoring -> proc/ignoring - proc/makeBody -> proc/make_body - proc/Arrival -> proc/arrival - proc/Opacity -> proc/opacity - proc/Overlay -> proc/overlay - proc/Animation -> proc/animation - proc/invertDir -> proc/invert_dir - proc/Compare -> proc/compare - proc/gameTimestamp -> proc/game_timestamp - proc/SQLtime -> proc/sqltime - proc/sortAssoc -> proc/sort_assoc - proc/mergeAssoc -> proc/merge_assoc - proc/Entries -> proc/entries - proc/Entries -> proc/entries - proc/Whitelist -> proc/whitelist - proc/setupGenetics -> proc/setup_genetics - proc/Feedback -> proc/feedback - proc/Broadcast -> proc/broadcast - proc/Element -> proc/element - proc/Arguments -> proc/arguments - proc/checkEvent -> proc/check_event - proc/spawnEvent -> proc/spawn_event - proc/forceEvent -> proc/force_event - proc/forceEvent -> proc/force_event - proc/getHoliday -> proc/get_holiday - proc/toggleWizardmode -> proc/toggle_wizardmode - proc/resetFrequency -> proc/reset_frequency - proc/Limited -> proc/limited - proc/Firewall -> proc/firewall - proc/ZChanged -> proc/zchanged - proc/Occupations -> proc/occupations - proc/Department -> proc/department - proc/Candidates -> proc/candidates - proc/Occupations -> proc/occupations - proc/Position -> proc/position - proc/Positions -> proc/positions - proc/AIPosition -> proc/aiposition - proc/Occupations -> proc/occupations - proc/Unassigned -> proc/unassigned - proc/Gathering -> proc/gathering - proc/Reached -> proc/reached - proc/loadWorld -> proc/load_world - proc/preloadTemplates -> proc/preload_templates - proc/Templates -> proc/templates - proc/Templates -> proc/templates - proc/Templates -> proc/templates - proc/Templates -> proc/templates - proc/Templates -> proc/templates - proc/Reservation -> proc/reservation - proc/Materials -> proc/materials - proc/ZChanged -> proc/zchanged - proc/findPAI -> proc/find_pai - proc/recruitWindow -> proc/recruit_window - proc/Messages -> proc/messages - proc/Trophies -> proc/trophies - proc/Reputation -> proc/reputation - proc/Trophies -> proc/trophies - proc/Persistence -> proc/persistence - proc/Persistence -> proc/persistence - proc/Messages -> proc/messages - proc/Message -> proc/message - proc/Trophies -> proc/trophies - proc/Roundtype -> proc/roundtype - proc/Reputation -> proc/reputation - proc/Paintings -> proc/paintings - proc/Paintings -> proc/paintings - proc/Profiling -> proc/profiling - proc/Profiling -> proc/profiling - proc/getShuttle -> proc/get_shuttle - proc/getDock -> proc/get_dock - proc/canEvac -> proc/can_evac - proc/requestEvac -> proc/request_evac - proc/emergencyDeregister -> proc/emergency_deregister - proc/cancelEvac -> proc/cancel_evac - proc/canRecall -> proc/can_recall - proc/autoEvac -> proc/auto_evac - proc/Environment -> proc/environment - proc/Environment -> proc/environment - proc/registerInfestation -> proc/register_infestation - proc/clearInfestation -> proc/clear_infestation - proc/Blockade -> proc/blockade - proc/Blockade -> proc/blockade - proc/Blockade -> proc/blockade - proc/Environment -> proc/environment - proc/Environment -> proc/environment - proc/Station -> proc/station - proc/toggleShuttle -> proc/toggle_shuttle - proc/moveShuttle -> proc/move_shuttle - proc/Populatedbcache -> proc/populatedbcache - proc/Roundstart -> proc/roundstart - proc/Roundend -> proc/roundend - proc/Started -> proc/started - proc/Progress -> proc/progress - proc/bucketEject -> proc/bucket_eject - proc/bucketJoin -> proc/bucket_join - proc/Behaviors -> proc/behaviors - proc/Behavior -> proc/behavior - proc/Actions -> proc/actions - proc/Behaviors -> proc/behaviors - proc/Costume -> proc/costume - proc/startButcher -> proc/start_butcher - proc/Butcher -> proc/butcher - proc/Effects -> proc/effects - proc/jostleCheck -> proc/jostle_check - proc/fallOut -> proc/fall_out - proc/safeRemove -> proc/safe_remove - proc/checkRemoval -> proc/check_removal - proc/pluckOut -> proc/pluck_out - proc/weaponDeleted -> proc/weapon_deleted - proc/Grilling -> proc/grilling - proc/Grilling -> proc/grilling - proc/Examine -> proc/examine - proc/Overlay -> proc/overlay - proc/onEquip -> proc/on_equip - proc/Knockoff -> proc/knockoff - proc/Equipped -> proc/equipped - proc/Dropped -> proc/dropped - proc/setSanity -> proc/set_sanity - proc/Nutrition -> proc/nutrition - proc/Repaint -> proc/repaint - proc/Actions -> proc/actions - proc/Unbuckle -> proc/unbuckle - proc/Process_Spacemove -> proc/process_spacemove - proc/Message -> proc/message - proc/checkTether -> proc/check_tether - proc/Purchase -> proc/purchase - proc/Signals -> proc/signals - proc/Component -> proc/component - proc/Component -> proc/component - proc/Transfer -> proc/transfer - proc/Transfer -> proc/transfer - proc/Component -> proc/component - proc/Component -> proc/component - proc/Components -> proc/components - proc/Component -> proc/component - proc/Component -> proc/component - proc/Component -> proc/component - proc/Component -> proc/component - proc/Components -> proc/components - proc/speechModification -> proc/speech_modification - proc/Disease -> proc/disease - proc/Disease -> proc/disease - proc/Disease -> proc/disease - proc/Disease -> proc/disease - proc/Disease -> proc/disease - proc/Disease -> proc/disease - proc/equippedChanged -> proc/equipped_changed - proc/checkEmbed -> proc/check_embed - proc/severancePackage -> proc/severance_package - proc/Projectile -> proc/projectile - proc/Element -> proc/element - proc/Element -> proc/element - proc/Refresh -> proc/refresh - proc/Generate -> proc/generate - proc/Generate_entry -> proc/generate_entry - proc/Generate -> proc/generate - proc/Generate_entry -> proc/generate_entry - proc/Refresh -> proc/refresh - proc/Refresh -> proc/refresh - proc/Refresh -> proc/refresh - proc/Configuration -> proc/configuration - proc/Metadata -> proc/metadata - proc/Generate -> proc/generate - proc/Generate_entry -> proc/generate_entry - proc/Bundle_entry -> proc/bundle_entry - proc/Group_entry -> proc/group_entry - proc/addEvent -> proc/add_event - proc/fireEvent -> proc/fire_event - proc/clearEvent -> proc/clear_event - proc/makeImg -> proc/make_img - proc/Pressure -> proc/pressure - proc/Restrain -> proc/restrain - proc/Consecutive -> proc/consecutive - proc/floorKick -> proc/floor_kick - proc/calfKick -> proc/calf_kick - proc/jumpingKnee -> proc/jumping_knee - proc/karateChop -> proc/karate_chop - proc/Tornado -> proc/tornado - proc/Throwback -> proc/throwback - proc/wristWrench -> proc/wrist_wrench - proc/backKick -> proc/back_kick - proc/kneeStomach -> proc/knee_stomach - proc/headKick -> proc/head_kick - proc/elbowDrop -> proc/elbow_drop - proc/tailSweep -> proc/tail_sweep - proc/faceScratch -> proc/face_scratch - proc/jugularCut -> proc/jugular_cut - proc/tailGrab -> proc/tail_grab - proc/Animation -> proc/animation - proc/Generation -> proc/generation - proc/Firedoors -> proc/firedoors - proc/Explosion -> proc/explosion - proc/isAvailable -> proc/is_available - proc/setCharging -> proc/set_charging - proc/Materials -> proc/materials - proc/Materials -> proc/materials - proc/Activate -> proc/activate - proc/Deactivate -> proc/deactivate - proc/Contents -> proc/contents - proc/Reflect -> proc/reflect - proc/openTip -> proc/open_tip - proc/canStrip -> proc/can_strip - proc/doStrip -> proc/do_strip - proc/Harmless -> proc/harmless - proc/failedEmbed -> proc/failed_embed - proc/tryEmbed -> proc/try_embed - proc/disableEmbedding -> proc/disable_embedding - proc/updateEmbedding -> proc/update_embedding - proc/updateDialog -> proc/update_dialog - proc/copyTurf -> proc/copy_turf - proc/Assimilate_Air -> proc/assimilate_air - proc/Lattice -> proc/lattice - proc/Initalize_Atmos -> proc/initalize_atmos - proc/handleRCL -> proc/handle_rcl - proc/Lattice -> proc/lattice - proc/Distance -> proc/distance - proc/Distance_cardinal -> proc/distance_cardinal - proc/visibilityChanged -> proc/visibility_changed - proc/toggleAI -> proc/toggle_ai - proc/adminGreet -> proc/admin_greet - proc/Default -> proc/default - proc/portalAnnounce -> proc/portal_announce - proc/FSecret -> proc/fsecret - proc/Assembly -> proc/assembly - proc/refreshBeam -> proc/refresh_beam - proc/switchListener -> proc/switch_listener - proc/queuedInsert -> proc/queued_insert - proc/initMap -> proc/init_map - proc/Dropoff -> proc/dropoff - proc/setupView -> proc/setup_view - proc/updateCursor -> proc/update_cursor - proc/refreshView -> proc/refresh_view - proc/refreshBay -> proc/refresh_bay - proc/preLaunch -> proc/pre_launch - proc/updateSelector -> proc/update_selector - proc/clearBay -> proc/clear_bay - proc/loadData -> proc/load_data - proc/setDropoff -> proc/set_dropoff - proc/setupExports -> proc/setup_exports - proc/generateRequisition -> proc/generate_requisition - proc/generateManifest -> proc/generate_manifest - proc/generateCombo -> proc/generate_combo - proc/setStyle -> proc/set_style - proc/Departing -> proc/departing - proc/preOpen -> proc/pre_open - proc/Sequence -> proc/sequence - proc/preReturn -> proc/pre_return - proc/deleteRubble -> proc/delete_rubble - proc/addGlow -> proc/add_glow - proc/endGlow -> proc/end_glow - proc/fadeAway -> proc/fade_away - proc/drawSelf -> proc/draw_self - proc/getForeground -> proc/get_foreground - proc/fadeAway -> proc/fade_away - proc/setStyle -> proc/set_style - proc/beginLaunch -> proc/begin_launch - proc/setupSmoke -> proc/setup_smoke - proc/drawSmoke -> proc/draw_smoke - proc/endLaunch -> proc/end_launch - proc/endLaunch -> proc/end_launch - proc/evidencebagEquip -> proc/evidencebag_equip - proc/Results -> proc/results - proc/Destroyed -> proc/destroyed - proc/runEvent -> proc/run_event - proc/checkLiked -> proc/check_liked - proc/countEggs -> proc/count_eggs - proc/dispensePrize -> proc/dispense_prize - proc/shouldCelebrate -> proc/should_celebrate - proc/makeWine -> proc/make_wine - proc/Consume -> proc/consume - proc/Connected -> proc/connected - proc/nutrimentMutation -> proc/nutriment_mutation - proc/applyChemicals -> proc/apply_chemicals - proc/adjustNutri -> proc/adjust_nutri - proc/adjustWater -> proc/adjust_water - proc/adjustHealth -> proc/adjust_health - proc/adjustToxic -> proc/adjust_toxic - proc/adjustPests -> proc/adjust_pests - proc/adjustWeeds -> proc/adjust_weeds - proc/getYield -> proc/get_yield - proc/Interviews -> proc/interviews - proc/keyLoop -> proc/key_loop - proc/seedRuins -> proc/seed_ruins - proc/Reaction -> proc/reaction - proc/Voucher -> proc/voucher - proc/Possible -> proc/possible - proc/Inventory -> proc/inventory - proc/Unequip -> proc/unequip - proc/Storage -> proc/storage - proc/Gibberish -> proc/gibberish - proc/Move_object -> proc/move_object - proc/Process_Grab -> proc/process_grab - proc/Process_Incorpmove -> proc/process_incorpmove - proc/canZMove -> proc/can_zmove - proc/Robotize -> proc/robotize - proc/Alienize -> proc/alienize - proc/Animalize -> proc/animalize - proc/resetIDS -> proc/reset_ids - proc/toggleIDS -> proc/toggle_ids - proc/fulfillContract -> proc/fulfill_contract - proc/signIncorrectly -> proc/sign_incorrectly - proc/fillCurrent -> proc/fill_current - proc/addFile -> proc/add_file - proc/Networks -> proc/networks - proc/Networks -> proc/networks - proc/handleInactive -> proc/handle_inactive - proc/defineRegion -> proc/define_region - proc/undefineRegion -> proc/undefine_region - proc/checkRegion -> proc/check_region - proc/initialiseModules -> proc/initialise_modules - proc/syncModules -> proc/sync_modules - proc/Generator -> proc/generator - proc/setAngle -> proc/set_angle - proc/Projectile -> proc/projectile - proc/Reagents -> proc/reagents - proc/Materials -> proc/materials - proc/RDevices -> proc/rdevices - proc/Insert_Item -> proc/insert_item - proc/sendEvent -> proc/send_event - proc/eventSent -> proc/event_sent - proc/triggerEvent -> proc/trigger_event - proc/eventTriggered -> proc/event_triggered - proc/Pressure -> proc/pressure - proc/Station -> proc/station - proc/Undocked -> proc/undocked - proc/Announce -> proc/announce - proc/linkShuttle -> proc/link_shuttle - proc/calculateStats -> proc/calculate_stats - proc/DBStuff -> proc/dbstuff - proc/canMove -> proc/can_move - proc/canDock -> proc/can_dock - proc/enterTransit -> proc/enter_transit - proc/setTimer -> proc/set_timer - proc/modTimer -> proc/mod_timer - proc/invertTimer -> proc/invert_timer - proc/timeLeft -> proc/time_left - proc/Console -> proc/console - proc/shuttleRotate -> proc/shuttle_rotate - proc/tgui_Topic -> proc/tgui_topic - proc/Purchase -> proc/purchase - proc/loadingAttempt -> proc/loading_attempt - proc/Credits -> proc/credits - proc/Element -> proc/element - proc/Element -> proc/element - proc/sortInsert -> proc/sort_insert - proc/sortMerge -> proc/sort_merge - proc/sortTim -> proc/sort_tim - proc/timSort -> proc/tim_sort - proc/binarySort -> proc/binary_sort - proc/Ascending -> proc/ascending - proc/mergeCollapse -> proc/merge_collapse - proc/Collapse -> proc/collapse - proc/mergeAt -> proc/merge_at - proc/gallopLeft -> proc/gallop_left - proc/gallopRight -> proc/gallop_right - proc/mergeLo -> proc/merge_lo - proc/mergeHi -> proc/merge_hi - proc/mergeSort -> proc/merge_sort - proc/Instances -> proc/instances - proc/AIBehaviors -> proc/aibehaviors - proc/Consume -> proc/consume - proc/Symptom -> proc/symptom - proc/Symptoms -> proc/symptoms - proc/Refresh -> proc/refresh - proc/Properties -> proc/properties - proc/Properties -> proc/properties - proc/Channel -> proc/channel - proc/Devolve -> proc/devolve - proc/Finalize -> proc/finalize - proc/Symptom -> proc/symptom - proc/Symptom -> proc/symptom - proc/Symptom -> proc/symptom - proc/Symptom -> proc/symptom - proc/Advance_Mix -> proc/advance_mix - proc/Viruses -> proc/viruses - proc/Togglelight -> proc/togglelight - proc/newTarget -> proc/new_target - proc/cancelAlarm -> proc/cancel_alarm - proc/triggerAlarm -> proc/trigger_alarm - proc/upgradeXRay -> proc/upgrade_xray - proc/removeXRay -> proc/remove_xray - proc/isMotion -> proc/is_motion - proc/upgradeMotion -> proc/upgrade_motion - proc/removeMotion -> proc/remove_motion - proc/Actions -> proc/actions - proc/Toggle_lock -> proc/toggle_lock - proc/Toggle_autoprocess -> proc/toggle_autoprocess - proc/Console -> proc/console - proc/Console -> proc/console - proc/isElectrified -> proc/is_electrified - proc/canAIControl -> proc/can_aicontrol - proc/canAIHack -> proc/can_aihack - proc/restorePower -> proc/restore_power - proc/hasPower -> proc/has_power - proc/removeMe -> proc/remove_me - proc/onlyOpen -> proc/only_open - proc/onlyClose -> proc/only_close - proc/closeDoor -> proc/close_door - proc/cycleClose -> proc/cycle_close - proc/cycleOpen -> proc/cycle_open - proc/openDoor -> proc/open_door - proc/returnText -> proc/return_text - proc/notContent -> proc/not_content - proc/popDown -> proc/pop_down - proc/shootAt -> proc/shoot_at - proc/setState -> proc/set_state - proc/updateTurrets -> proc/update_turrets - proc/fireEngine -> proc/fire_engine - proc/hasFuel -> proc/has_fuel - proc/consumeFuel -> proc/consume_fuel - proc/canAccess -> proc/can_access - proc/mineEffect -> proc/mine_effect - proc/Trigger -> proc/trigger - proc/transmitInstructions -> proc/transmit_instructions - proc/decreaseUses -> proc/decrease_uses - proc/startUp -> proc/start_up - proc/startLaunch -> proc/start_launch - proc/endLaunch -> proc/end_launch - proc/Surface -> proc/surface - proc/staticDrawables -> proc/static_drawables - proc/Haunted -> proc/haunted - proc/Extinguisher -> proc/extinguisher - proc/updateTank -> proc/update_tank - proc/updateTank -> proc/update_tank - proc/useResource -> proc/use_resource - proc/checkResource -> proc/check_resource - proc/canPlace -> proc/can_place - proc/getMobhook -> proc/get_mobhook - proc/layCable -> proc/lay_cable - proc/Choices -> proc/choices - proc/removeOverlays -> proc/remove_overlays - proc/Consume -> proc/consume - proc/stopRumble -> proc/stop_rumble - proc/setAngle -> proc/set_angle - proc/isTerminator -> proc/is_terminator - proc/removeTarget -> proc/remove_target - proc/spawnDebris -> proc/spawn_debris - proc/Spread_Vein -> proc/spread_vein - proc/Change_Ore -> proc/change_ore - proc/Capacity -> proc/capacity - proc/Temperature -> proc/temperature - proc/Temperature -> proc/temperature - proc/Slippery -> proc/slippery - proc/Manager -> proc/manager - proc/ICIssue -> proc/icissue - proc/makepAI -> proc/makep_ai - proc/startSinglo -> proc/start_singlo - proc/Manager -> proc/manager - proc/makeTraitors -> proc/make_traitors - proc/makeChangelings -> proc/make_changelings - proc/makeRevs -> proc/make_revs - proc/makeWizard -> proc/make_wizard - proc/makeCult -> proc/make_cult - proc/makeAliens -> proc/make_aliens - proc/makeDeathsquad -> proc/make_deathsquad - proc/Modified -> proc/modified - proc/makeEmergencyresponseteam -> proc/make_emergencyresponseteam - proc/makeRevenant -> proc/make_revenant - proc/Tickets -> proc/tickets - proc/Interaction -> proc/interaction - proc/Recipient -> proc/recipient - proc/Resolve -> proc/resolve - proc/Retitle -> proc/retitle - proc/view_var_Topic -> proc/view_var_topic - proc/Zombify -> proc/zombify - proc/createSpecial -> proc/create_special - proc/stingAtom -> proc/sting_atom - proc/Positioning -> proc/positioning - proc/pollCultists -> proc/poll_cultists - proc/devilInfo -> proc/devil_info - proc/equipERT -> proc/equip_ert - proc/Contents -> proc/contents - proc/Contents -> proc/contents - proc/addMemories -> proc/add_memories - proc/addObjectives -> proc/add_objectives - proc/Harvest -> proc/harvest - proc/Fabricate -> proc/fabricate - proc/Integrate -> proc/integrate - proc/Integrate -> proc/integrate - proc/Machine -> proc/machine - proc/Barricade -> proc/barricade - proc/Swarmer -> proc/swarmer - proc/Swarmers -> proc/swarmers - proc/Experience -> proc/experience - proc/returnVictim -> proc/return_victim - proc/Conductivity -> proc/conductivity - proc/Adjacency -> proc/adjacency - proc/nullifyNode -> proc/nullify_node - proc/Connects -> proc/connects - proc/findConnecting -> proc/find_connecting - proc/isConnectable -> proc/is_connectable - proc/Directions -> proc/directions - proc/Directions -> proc/directions - proc/returnPipenet -> proc/return_pipenet - proc/setPipenet -> proc/set_pipenet - proc/replacePipenet -> proc/replace_pipenet - proc/returnPipenets -> proc/return_pipenets - proc/addMember -> proc/add_member - proc/addMember -> proc/add_member - proc/toggleFirepit -> proc/toggle_firepit - proc/canSuicide -> proc/can_suicide - proc/lightUp -> proc/light_up - proc/Extinguish -> proc/extinguish - proc/tryScan -> proc/try_scan - proc/Completed -> proc/completed - proc/Completed -> proc/completed - proc/Accepted -> proc/accepted - proc/Burning -> proc/burning - proc/updateDialog -> proc/update_dialog - proc/Release -> proc/release - proc/Reserve -> proc/reserve - proc/ZLevels -> proc/zlevels - proc/Recharge -> proc/recharge - proc/Resonance -> proc/resonance - proc/makeTrail -> proc/make_trail - proc/getTrail -> proc/get_trail - proc/spreadFire -> proc/spread_fire - proc/knockOver -> proc/knock_over - proc/Ability -> proc/ability - proc/Ability -> proc/ability - proc/Ellipsis -> proc/ellipsis - proc/Knockdown -> proc/knockdown - proc/Knockdown -> proc/knockdown - proc/Knockdown -> proc/knockdown - proc/Knockdown -> proc/knockdown - proc/Knockdown -> proc/knockdown - proc/Immobilized -> proc/immobilized - proc/Immobilized -> proc/immobilized - proc/Immobilize -> proc/immobilize - proc/Immobilized -> proc/immobilized - proc/Immobilized -> proc/immobilized - proc/Paralyzed -> proc/paralyzed - proc/Paralyzed -> proc/paralyzed - proc/Paralyze -> proc/paralyze - proc/Paralyzed -> proc/paralyzed - proc/Paralyzed -> proc/paralyzed - proc/Immobility -> proc/immobility - proc/Immobility -> proc/immobility - proc/Immobility -> proc/immobility - proc/Unconscious -> proc/unconscious - proc/Unconscious -> proc/unconscious - proc/Unconscious -> proc/unconscious - proc/Unconscious -> proc/unconscious - proc/Unconscious -> proc/unconscious - proc/Sleeping -> proc/sleeping - proc/Sleeping -> proc/sleeping - proc/Sleeping -> proc/sleeping - proc/Sleeping -> proc/sleeping - proc/Sleeping -> proc/sleeping - proc/Sleeping -> proc/sleeping - proc/Display -> proc/display - proc/lockIcons -> proc/lock_icons - proc/generateGenerator -> proc/generate_generator - proc/debugOutput -> proc/debug_output - proc/Species -> proc/species - proc/Consume -> proc/consume - proc/Contents -> proc/contents - proc/Destination -> proc/destination - proc/flushAnimation -> proc/flush_animation - proc/Disposals -> proc/disposals - proc/Researched -> proc/researched - proc/Researched -> proc/researched - proc/Visible -> proc/visible - proc/Available -> proc/available - proc/linkTurfs -> proc/link_turfs - proc/ejectRooms -> proc/eject_rooms - proc/promptExit -> proc/prompt_exit - proc/storeRoom -> proc/store_room - proc/Direction -> proc/direction - proc/Chargeup -> proc/chargeup - proc/Shapeshift -> proc/shapeshift - proc/Restore -> proc/restore - proc/casterDeath -> proc/caster_death - proc/shapeDeath -> proc/shape_death - proc/Retract -> proc/retract - proc/restoreEars -> proc/restore_ears - proc/restoreEars -> proc/restore_ears - proc/Restart -> proc/restart - proc/Refresh -> proc/refresh - proc/Version -> proc/version - proc/Complete -> proc/complete - proc/Process -> proc/process - proc/Revision -> proc/revision - proc/Broadcast -> proc/broadcast - proc/Broadcast -> proc/broadcast - proc/Message -> proc/message - proc/Visibility -> proc/visibility - proc/Service -> proc/service - proc/Commands -> proc/commands - proc/Command -> proc/command - proc/Channel -> proc/channel - proc/Commands -> proc/commands - proc/Command -> proc/command - proc/Response -> proc/response - proc/Message -> proc/message - proc/Channels -> proc/channels - proc/Channel -> proc/channel - proc/Request -> proc/request - proc/Reattach -> proc/reattach - proc/Request -> proc/request - proc/Commands -> proc/commands - proc/Command -> proc/command - proc/Response -> proc/response - proc/Response -> proc/response - proc/Command -> proc/command - proc/Broadcast -> proc/broadcast - proc/Counter -> proc/counter - proc/Asphyxiate_stage_3_4 -> proc/asphyxiate_stage_3_4 - proc/Asphyxiate -> proc/asphyxiate - proc/Asphyxiate_death -> proc/asphyxiate_death - proc/Replace -> proc/replace - proc/Firestacks_stage_4 -> proc/firestacks_stage_4 - proc/Firestacks_stage_5 -> proc/firestacks_stage_5 - proc/Alkali_fire_stage_4 -> proc/alkali_fire_stage_4 - proc/Alkali_fire_stage_5 -> proc/alkali_fire_stage_5 - proc/Flesheat -> proc/flesheat - proc/Flesh_death -> proc/flesh_death - proc/Activate -> proc/activate - proc/mobShock -> proc/mob_shock - proc/gravShock -> proc/grav_shock - proc/anomalyEffect -> proc/anomaly_effect - proc/anomalyNeutralize -> proc/anomaly_neutralize - proc/Chilled -> proc/chilled - proc/setPersonality -> proc/set_personality - proc/alertUpdate -> proc/alert_update - proc/Activate -> proc/activate - proc/Deactivate -> proc/deactivate - proc/Interact -> proc/interact - proc/Pickup_ores -> proc/pickup_ores - proc/Contents -> proc/contents - proc/emptyStorage -> proc/empty_storage - proc/refreshID -> proc/refresh_id - proc/Armrest -> proc/armrest - proc/Contents -> proc/contents - proc/Execute -> proc/execute - proc/_ckeyEx -> proc/_ckey_ex - proc/_replacetextEx -> proc/_replacetext_ex - proc/Disguise -> proc/disguise - proc/Stealth -> proc/stealth - proc/Stealth -> proc/stealth - proc/Adrenaline -> proc/adrenaline - proc/ownerCheck -> proc/owner_check - proc/Scientist -> proc/scientist - proc/Retrieve -> proc/retrieve - proc/Disguise -> proc/disguise - proc/Droppoint -> proc/droppoint - proc/Snapshot -> proc/snapshot - proc/Dispense -> proc/dispense - proc/Dispense -> proc/dispense - proc/Retrieve -> proc/retrieve - proc/Pulse_Area -> proc/pulse_area - proc/Be_Pulsed -> proc/be_pulsed - proc/Construct -> proc/construct - proc/Available -> proc/available - proc/nullifyPipenet -> proc/nullify_pipenet - proc/Connections -> proc/connections - proc/Unavailable -> proc/unavailable - proc/Contract -> proc/contract - proc/Choices -> proc/choices - proc/Manifest -> proc/manifest - proc/Handcuffed -> proc/handcuffed - proc/create_modularInterface -> proc/create_modular_interface - proc/queueAlarm -> proc/queue_alarm - proc/adjustHealth -> proc/adjust_health - proc/isStuck -> proc/is_stuck - proc/Read_Memory -> proc/read_memory - proc/Write_Memory -> proc/write_memory - proc/Possess -> proc/possess - proc/Devices -> proc/devices - proc/Current -> proc/current - proc/Readable -> proc/readable - proc/can_zFall -> proc/can_z_fall - proc/intercept_zImpact -> proc/intercept_z_impact - proc/onZImpact -> proc/on_zimpact - proc/can_zTravel -> proc/can_z_travel - proc/can_zFall -> proc/can_z_fall - proc/can_start_zFall -> proc/can_start_z_fall - proc/try_start_zFall -> proc/try_start_z_fall - proc/zFall_Move -> proc/z_fall_move - proc/Recover -> proc/recover - proc/startTimer -> proc/start_timer - proc/resistField -> proc/resist_field - proc/breakCube -> proc/break_cube - proc/Actions -> proc/actions - proc/recalculateChannels -> proc/recalculate_channels - proc/resetChannels -> proc/reset_channels - proc/Generator -> proc/generator - proc/Extinguish -> proc/extinguish - proc/Display -> proc/display - proc/findQueen -> proc/find_queen - proc/makeSkeleton -> proc/make_skeleton - proc/makeUncloneable -> proc/make_uncloneable - proc/Togglewings -> proc/togglewings - proc/equipOutfit -> proc/equip_outfit - proc/Read_Memory -> proc/read_memory - proc/Write_Memory -> proc/write_memory - proc/switchCamera -> proc/switch_camera - proc/Routine -> proc/routine - proc/Routine -> proc/routine - proc/makePAI -> proc/make_pai - proc/Lockdown -> proc/lockdown - proc/Emagged -> proc/emagged - proc/shootAt -> proc/shoot_at - proc/Read_Memory -> proc/read_memory - proc/Write_Memory -> proc/write_memory - proc/Deploy_The_Cats -> proc/deploy_the_cats - proc/Read_Memory -> proc/read_memory - proc/Write_Memory -> proc/write_memory - proc/Gondola -> proc/gondola - proc/Found_You -> proc/found_you - proc/Acquire_Victim -> proc/acquire_victim - proc/Manifest -> proc/manifest - proc/Reset_View -> proc/reset_view - proc/On_Stage -> proc/on_stage - proc/Targets -> proc/targets - proc/Threats -> proc/threats - proc/Direction -> proc/direction - proc/Surroundings -> proc/surroundings - proc/Confinement -> proc/confinement - proc/Continue -> proc/continue - proc/Patience -> proc/patience - proc/Patience -> proc/patience - proc/Objects -> proc/objects - proc/Objects -> proc/objects - proc/Copy_Parent -> proc/copy_parent - proc/isStuck -> proc/is_stuck - proc/Recover -> proc/recover - proc/useGust -> proc/use_gust - proc/Deflate -> proc/deflate - proc/Feedstop -> proc/feedstop - proc/Proximity -> proc/proximity - proc/updateAir -> proc/update_air - proc/dismantleFloor -> proc/dismantle_floor - proc/layCable -> proc/lay_cable - proc/getPlasma -> proc/get_plasma - proc/adjustPlasma -> proc/adjust_plasma - proc/usePlasma -> proc/use_plasma - proc/Impregnate -> proc/impregnate - proc/Cannibalize_Body -> proc/cannibalize_body - proc/chunkGenerated -> proc/chunk_generated - proc/updateVisibility -> proc/update_visibility - proc/updateChunk -> proc/update_chunk - proc/removeCamera -> proc/remove_camera - proc/addCamera -> proc/add_camera - proc/visibilityChanged -> proc/visibility_changed - proc/hasChanged -> proc/has_changed - proc/Appearance -> proc/appearance - proc/Recovery -> proc/recovery - proc/Neutral -> proc/neutral - proc/Startup -> proc/startup - proc/Recovery -> proc/recovery - proc/Neutral -> proc/neutral - proc/Reaction -> proc/reaction - proc/Retaliate -> proc/retaliate

Changelog

🆑
code: Enforces camel case in DM proc names.
/:cl:

@Tsar-Salat
Copy link
Contributor

Tsar-Salat commented Aug 21, 2024 •
edited
Loading

Swapping to camelCase over snake_case is probably going to make TG ports harder ngl

They aren't exactly clear on keeping a theme for procs versus typepath, but I figure I should put this here nonetheless

@PowerfulBacon
Copy link
Member Author

Ah, typo in the PR name. Should read snake_case

@PowerfulBacon PowerfulBacon changed the title Enforce camel case in DM proc names. Enforce snake case in DM proc names. Aug 21, 2024
@PowerfulBacon
Copy link
Member Author

Script is almost functioning as intended now, just need to optimise it, fix some exceptional cases and then run it. I could do it a lot better, but it just needs to be a quick script that works once and never again.

@EvilDragonfiend
Copy link
Member

will we have an exception list?

@PowerfulBacon
Copy link
Member Author

There's a phrase that will cause files to be skipped if it's found. This is applied to TGS, DBcore and ill exclude Initialize and Destroy

@PowerfulBacon
Copy link
Member Author

Not sure how to do this in a way without destroying compatability with TG, will get back to this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Crossedfall Crossedfall Awaiting requested review from Crossedfall Crossedfall will be requested when the pull request is marked ready for review Crossedfall is a code owner

Assignees
No one assigned
Labels
Code Improvement GitHub Priority: High Tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PowerfulBacon @Tsar-Salat @EvilDragonfiend